Skip to content

[material-ui][Tooltip] Support event handlers with extra parameters #41320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2024
Merged

[material-ui][Tooltip] Support event handlers with extra parameters #41320

merged 2 commits into from
Mar 13, 2024

Conversation

@LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 29, 2024

Resolves the problem with not propagating additional parameters here: mui/mui-x#12248 (comment).

If you do not agree with the proposal—we'll need to go for a different approach on X side.

@LukasTy LukasTy added scope: tooltip Changes related to the tooltip. package: material-ui package: joy-ui Specific to Joy UI. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. labels Feb 29, 2024
@LukasTy LukasTy self-assigned this Feb 29, 2024
@mui-bot
Copy link

mui-bot commented Feb 29, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-41320--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 14c47d1

siriwatknp
siriwatknp reviewed Mar 1, 2024
View reviewed changes
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am good with the proposal. Let's wait @michaldudak.

michaldudak
michaldudak approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@siriwatknp siriwatknp merged commit 9e97e73 into mui:master Mar 13, 2024
@siriwatknp siriwatknp mentioned this pull request Mar 13, 2024
Merged
@LukasTy LukasTy deleted the support-extra-tooltip-handler-params branch March 13, 2024 07:38
This was referenced May 19, 2024
Open
Open
Open
This was referenced May 19, 2024
Open
Open
@nachodev-ui nachodev-ui mentioned this pull request May 20, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 20, 2024
Open
@jfnw-capco jfnw-capco mentioned this pull request May 20, 2024
Open
This was referenced May 20, 2024
Open
Open
This was referenced May 20, 2024
Open
Open
@sergivj sergivj mentioned this pull request May 21, 2024
Open
@NOUIY NOUIY mentioned this pull request May 21, 2024
Open
@NOUIY NOUIY mentioned this pull request May 25, 2024
Open
This was referenced May 25, 2024
Open
Open
This was referenced May 25, 2024
Open
Open
@mattboddy47 mattboddy47 mentioned this pull request May 25, 2024
Open
This was referenced May 25, 2024
Open
Open
@arddluma arddluma mentioned this pull request May 25, 2024
Closed
This was referenced May 25, 2024
Open
Open
@realmarkoprifti realmarkoprifti mentioned this pull request May 25, 2024
Open
@nachodev-ui nachodev-ui mentioned this pull request May 25, 2024
Open
@FaroukAmr FaroukAmr mentioned this pull request May 25, 2024
Open
This was referenced May 26, 2024
Open
Open
Open
@Poseidon-G Poseidon-G mentioned this pull request May 26, 2024
Open
@GitLukeW GitLukeW mentioned this pull request May 26, 2024
Open
@NOUIY NOUIY mentioned this pull request May 26, 2024
Open
@2310781001 2310781001 mentioned this pull request May 26, 2024
Open
@syedabdullahali syedabdullahali mentioned this pull request May 28, 2024
Open
This was referenced May 28, 2024
Open
Open
Open
@heliumtank92 heliumtank92 mentioned this pull request Jun 8, 2024
Open
@Helmut-Tischler Helmut-Tischler mentioned this pull request Jun 10, 2024
Open
This was referenced Jun 15, 2024
Open
Open
@dsypasit dsypasit mentioned this pull request Jun 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaldudak michaldudak michaldudak approved these changes

@siriwatknp siriwatknp siriwatknp approved these changes

Assignees

@LukasTy LukasTy

Labels

package: joy-ui Specific to Joy UI. scope: tooltip Changes related to the tooltip. type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@LukasTy @mui-bot @michaldudak @siriwatknp