Skip to content

[system] Use ReadonlyArray for CSS related types #40972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2024
Merged

[system] Use ReadonlyArray for CSS related types #40972

merged 1 commit into from
Feb 7, 2024

Conversation

@siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Feb 7, 2024 •
edited by oliviertassinari
Loading

Root cause

The sx prop uses csstype which has ReadonlyArray changes in 3.1.3 whereas CSSObject comes from emotion

Changes

Related to #40750

@siriwatknp siriwatknp added typescript scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI labels Feb 7, 2024
@siriwatknp siriwatknp mentioned this pull request Feb 7, 2024
Merged
@mui-bot
Copy link

mui-bot commented Feb 7, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-40972--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 1511a7f

@siriwatknp siriwatknp requested review from a team, brijeshb42 and mnajdova February 7, 2024 04:54
@siriwatknp siriwatknp mentioned this pull request Feb 7, 2024
Merged
1 task
Janpot
Janpot approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@brijeshb42 brijeshb42 merged commit af92b52 into mui:master Feb 7, 2024
@oliviertassinari oliviertassinari changed the title [system] use ReadonlyArray for CSS related types [system] Use ReadonlyArray for CSS related types Feb 7, 2024
@oliviertassinari oliviertassinari mentioned this pull request Feb 7, 2024
Open
This was referenced May 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brijeshb42 brijeshb42 brijeshb42 approved these changes

@Janpot Janpot Janpot approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

No one assigned

Labels

scope: system The system, the design tokens / styling foundations used across components. eg. @mui/system with MUI typescript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@siriwatknp @mui-bot @brijeshb42 @Janpot