Skip to content

[pull] master from Azure:master#1638

Merged
pull[bot] merged 1 commit intomudsut4ke:masterfrom
sonic-net:master
Jul 4, 2021
Merged

[pull] master from Azure:master#1638
pull[bot] merged 1 commit intomudsut4ke:masterfrom
sonic-net:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Jul 4, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

…m calls (#7987)

Why I did it
Currently hostcfgd is implemented in a way each feature which is enabled/disabled triggering execution of systemctl enable/unmask commands which eventually trigger 'systemctl daemon-reload' command.
Each call like this cost 0.6s and overall add a overhead of ~12 seconds of CPU time.
This change will verify the desired state of a feature and the current state of this feature on systemd and trigger a system call only when must.

How I did it
Check each feature status on systemd before executing a system call to enable and reload the systemctl daemon.

How to verify it
Build an image with this change and observe less system calls are executed.

Signed-off-by: Shlomi Bitton <[email protected]>
@pull pull bot added the ⤵️ pull label Jul 4, 2021
@pull pull bot merged commit d99595a into mudsut4ke:master Jul 4, 2021
pariwat pushed a commit to pariwat/sonic-buildimage that referenced this pull request Sep 10, 2021
19615e3 Fixing db_migrator for Feature table (mudsut4ke#1674)
d1c1c61 [tests]: skip some dynamic port breakout unit tests (mudsut4ke#1677)
25669c3 [CI] sonic-config-engine now depends on SONiC YANG packages (mudsut4ke#1675)
3ff68c4 [neighbor-advertiser] delete the tunnel maps appropriately (mudsut4ke#1663)
a425ca2 [config] support for configuring muxcable to manual mode of operation  (mudsut4ke#1642)
25e17de [show platform summary] Add chassis hardware info to platform summary and version (mudsut4ke#1624)
f5f2a00 [db_migrator] fix old 1911 feature config migration to a new one. (mudsut4ke#1635)
56db162 [config] Fix config int add incorrect ip (mudsut4ke#1414)
1da879c [db_migrator][Mellanox] Update Mellanox buffer migrator with 2km-cable supported (mudsut4ke#1564)
c2b760f [sonic_package_manager] flush once finished saving docker image into temporary file (mudsut4ke#1638)
cd69473 Replace swsssdk.ConfigDBConnector and SonicDBConfig with swsscommon implementation (mudsut4ke#1620)
5f20365 Change to use rvtysh when calling the show commands (mudsut4ke#1572)
51d6bf5 Fix Aboot breakage in sonic package manager in sonic-installer (mudsut4ke#1625)
18bed46 [console][show] Force refresh all lines status during show line (mudsut4ke#1641)
b616cd9 [TPID CONFIG] Added TPID configuration CLI support (mudsut4ke#1618)
01eb4b1 [show] support for show muxcable firmware version of only active banks (mudsut4ke#1629)
7744c8d [fdb]cli: fdb entries are cleared according to vlan or port or vlan&&port (mudsut4ke#657)
e23c5ee Add psu hardware revision to psushow table (mudsut4ke#1601)
f1726fe Make advance_version_for_expected_database available for other db migrator test cases as well (mudsut4ke#1614)
5d1ad05 [show] add support for muxcable metrics (mudsut4ke#1615)
feeab29 [config] Sort Config Db When Saving (mudsut4ke#1623)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant