Skip to content

[pull] master from Azure:master#1467

Merged
pull[bot] merged 2 commits intomudsut4ke:masterfrom
sonic-net:master
Mar 25, 2021
Merged

[pull] master from Azure:master#1467
pull[bot] merged 2 commits intomudsut4ke:masterfrom
sonic-net:master

Conversation

@pull
Copy link
Copy Markdown

@pull pull bot commented Mar 25, 2021

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

Junchao-Mellanox and others added 2 commits March 25, 2021 14:28
…rm API will be called by multiple daemons (#7114)

- Why I did it
The existing Fan led and Psu led object initialize itself to green color in init method. However, there are multiple daemons calls sonic platform API and there could be a case that:

A PSU is removed from system
Reboot switch
psud detects that 1 PSU is missing and set PSU led to red
Other daemon just start up and call sonic platform API, the API set PSU led to green by call PsuLed.init
This PR is a partial fix for the issue. As we also need guarantee that the led is initialized with a correct value. I checked existing psud and thermalctld code. psud always initialize the PSU led color on boot up, thermalcltd need some changes to initialize led color on the first run

- How I did it
Remove the led color initialization code from FanLed.init and PsuLed.init

- How to verify it
Manual test
Signed-off-by: Guohan Lu <lguohan@gmail.com>
@pull pull bot added the ⤵️ pull label Mar 25, 2021
@pull pull bot merged commit dbc7a45 into mudsut4ke:master Mar 25, 2021
pariwat pushed a commit to pariwat/sonic-buildimage that referenced this pull request Sep 10, 2021
this PR updates the following commits in sonic-utilities

13ce4b6 [show][config] fix show mux status health field; add support for hwmode functionality to toggle mux, check mux direction for Y cable (mudsut4ke#1467)
f78e7ce [acl-loader] Improve input validation for acl_loader (mudsut4ke#1479)
748dbbf [show] Fix 'show mac' output, when FDB entry with Vlan 1 is present (mudsut4ke#1368)
64604db [acl] Expand VLAN into VLAN members when creating an ACL table (mudsut4ke#1475)
10de91d [config reload]: On dual ToR systems, cache ARP and FDB tables (mudsut4ke#1465)
10a359a [Mellanox] Change mellanox buffer migrator for new SKU Mellanox-SN2700-D40C8S8 (mudsut4ke#1470)
38c8e00 [acl-loader] Add support for matching on ICMP and VLAN info (mudsut4ke#1469)
e555ea9 [SKU creator] fix wrong speed in case breakout of 2x50 (mudsut4ke#1380)
4a78c01 [config] Enable/disable container monitoring when starting/stopping the services. (mudsut4ke#1471)
dd3c2c3 [warm-reboot] Check if warm restart flag is set when issuing a warm-reboot (mudsut4ke#1460)
e32b5ac Add soft-reboot reboot type (mudsut4ke#1453)
8b3bc18 [reload] Improve reload by using sonic.target. (mudsut4ke#1199)
99673bc [reboot] Add platform-specific reboot cause update hook (mudsut4ke#1454)
2f6e36e [CLI][techsupport] Add NOOP option for commands that did not have that option (mudsut4ke#1445)
1fa4b94 [psushow] Add more output columns; Add option to output in JSON format (mudsut4ke#1416)
79ccd03 [show] cli support for show muxcable cableinfo (mudsut4ke#1448)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants