Skip to content

fix(model): do not assume success when deleting a model process #7963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mudler merged 3 commits into from
Jan 10, 2026
Merged

fix(model): do not assume success when deleting a model process #7963

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2aa24e
fix(model): do not assume success when deleting a model process
jroeber Jan 10, 2026
2e5e89f
Update pkg/model/process.go
jroeber Jan 10, 2026
b4e565c
Merge branch 'master' into fix-model-deletion-assumption
jroeber Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions pkg/model/process.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ func (ml *ModelLoader) deleteProcess(s string) error {
return fmt.Errorf("model %s not found", s)
}

defer delete(ml.models, s)

retries := 1
for model.GRPC(false, ml.wd).IsBusy() {
xlog.Debug("Model busy. Waiting.", "model", s)
Expand All @@ -48,6 +46,7 @@ func (ml *ModelLoader) deleteProcess(s string) error {
if process == nil {
xlog.Error("No process", "model", s)
// Nothing to do as there is no process
delete(ml.models, s)
return nil
}

Expand All @@ -56,6 +55,10 @@ func (ml *ModelLoader) deleteProcess(s string) error {
xlog.Error("(deleteProcess) error while deleting process", "error", err, "model", s)
}

if err != nil {
delete(ml.models, s)
}

return err
}

Expand Down