Skip to content

jq: New Package#5526

Merged
lazka merged 2 commits intomsys2:masterfrom
bwijen:jq
Jul 28, 2025
Merged

jq: New Package#5526
lazka merged 2 commits intomsys2:masterfrom
bwijen:jq

Conversation

@bwijen
Copy link
Contributor

@bwijen bwijen commented Jul 22, 2025

Port jq (and dependency oniguruma) from MINGW:

Solves: #2570

Port jq (and dependency oniguruma) from MINGW
@lazka
Copy link
Member

lazka commented Jul 25, 2025

Do we really need to make it look for Windows USERPROFILE? Our cygwin tools usually don't do that, see https://www.msys2.org/docs/configuration/

other than that I'm fine with adding it.

@bwijen
Copy link
Contributor Author

bwijen commented Jul 26, 2025

Do we really need to make it look for Windows USERPROFILE? Our cygwin tools usually don't do that, see https://www.msys2.org/docs/configuration/

other than that I'm fine with adding it.

Indeed we shouldn't, we have db_home for that.
I've taken the actual commit from the jq devs and reverse applied it.
See:
jqlang/jq#3114
https://github.com/bwijen/MSYS2-packages/blob/485eec87/jq/PKGBUILD#L22-L23

@lazka
Copy link
Member

lazka commented Jul 28, 2025

ah, revert. ok.

@lazka
Copy link
Member

lazka commented Jul 28, 2025

I still don't quite understand, the upstream code looks fine as is. What are you trying to change with the revert?

@jeremyd2019
Copy link
Member

When I read it, it did look like the code was fine, it was just the test that was broken (it assumed running in an msys shell meant it was running a win32 binary)

fake cygwin for tests to avoid weird msys logic
@lazka
Copy link
Member

lazka commented Jul 28, 2025

ok, thanks, avoided by changing uname to Cygwin

@lazka lazka merged commit 1fe85ed into msys2:master Jul 28, 2025
2 checks passed
@lazka
Copy link
Member

lazka commented Jul 28, 2025

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants