llvm: fix llvm-config for Cygwin #5351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyd2019
force-pushed
the
llvm-config-fix
branch
from
3c7e634 to
1673347
Compare
Member
Author
jeremyd2019
force-pushed
the
llvm-config-fix
branch
from
abed426 to
0178c47
Compare
Member
|
That reminds me of the patch in msys2/MINGW-packages@2ad570c but the commit message isn't helpful on how this was fixed (I guess not building with CMAKE_DLL_NAME_WITH_SOVERSION?) |
jeremyd2019
force-pushed
the
llvm-config-fix
branch
from
0178c47 to
8d5e148
Compare
Member
Author
|
I believe it was fixed upstream, by adding the |
Member
Author
|
My upstream PR was merged, so I'll merge this too now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5350
--libfilesand--libnamesreturns the (path to the) DLL, not the import library. I don't know if that's significant or not.