Skip to content

Refactor queue to be lazy #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ankur22 wants to merge 1 commit into from
Closed

Refactor queue to be lazy #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions taskqueue/queuer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,12 @@ func New(registerCallback func() func(func() error)) *TaskQueue {
// this is to work around the fact that RegistrerCallback doesn't know about Task
// related to https://github.com/golang/go/issues/8082
internal := func() func(Task) {
f := registerCallback()
enqueueCallback := registerCallback()
return func(t Task) {
f(t)
enqueueCallback(t)
}
}
tq := &TaskQueue{
callback: internal(),
registerCallback: internal,
}
return tq
Expand All @@ -44,15 +43,17 @@ func (tq *TaskQueue) Close() {
if tq.closed {
return
}
tq.closed = true
if tq.callback == nil {
tq.callback = tq.registerCallback()
}
if tq.callback == nil { // already something queued
tq.queue = append(tq.queue, func() error {
tq.Close()
return nil
})
return
}

tq.closed = true
tq.callback(func() error { return nil })
}

Expand All @@ -64,6 +65,9 @@ func (tq *TaskQueue) Queue(t Task) {
if tq.closed {
return
}
if tq.callback == nil {
tq.callback = tq.registerCallback()
}
if tq.callback == nil { // already something queued
tq.queue = append(tq.queue, t)
return
Expand Down
Loading