Conversation
56560ca to
a3fa300
Compare
Owner
Author
|
I will dry run the changes and run some tests on this. and update here |
msosyak
commented
Jul 15, 2021
Owner
Author
|
Faced an issue when trying to build docker-ptf as it's dependent on libsai but it is also deb9 based so the build failed due to dependencies issue. But syncd-rpc works well with old docker ptf |
430cb04 to
245e433
Compare
98efbd0 to
decbb5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The BFN SDK depends on thrift 0.13.0 and in the case syncd-rpc there is conflict in syncd as it should be linked with thrift 0.11.0 and 0.13.0 which in addition are build with different options (force boost ptr).
How I did it
To resolve the issue above I have added a new target under the BFN platform to build thrift 0.13.0. I copy past the Debian folder to build thrift from the default sonic thrift target as Debian rules in thrift sources are broken(I was not able to build thrift by them).
Also, I have added few patches to SAI as there some issues that should be fixed to build saithrift server within thrift 0.13.0
To review, patches go-to PR in SAI msosyak/SAI#1
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)