Skip to content

RPC thrift 13#3

Closed
msosyak wants to merge 4 commits intomasterfrom
myron/rpc
Closed

RPC thrift 13#3
msosyak wants to merge 4 commits intomasterfrom
myron/rpc

Conversation

@msosyak
Copy link
Copy Markdown
Owner

@msosyak msosyak commented Jul 7, 2021

Why I did it

The BFN SDK depends on thrift 0.13.0 and in the case syncd-rpc there is conflict in syncd as it should be linked with thrift 0.11.0 and 0.13.0 which in addition are build with different options (force boost ptr).

How I did it

To resolve the issue above I have added a new target under the BFN platform to build thrift 0.13.0. I copy past the Debian folder to build thrift from the default sonic thrift target as Debian rules in thrift sources are broken(I was not able to build thrift by them).

Also, I have added few patches to SAI as there some issues that should be fixed to build saithrift server within thrift 0.13.0
To review, patches go-to PR in SAI msosyak/SAI#1

How to verify it

make init
time NOJESSIE=1 NOSTRETCH=1 make configure PLATFORM=barefoot
time NOJESSIE=1 NOSTRETCH=1 make all

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106

Description for the changelog

A picture of a cute animal (not mandatory but encouraged)

@msosyak msosyak force-pushed the myron/rpc branch 2 times, most recently from 56560ca to a3fa300 Compare July 15, 2021 08:26
@msosyak
Copy link
Copy Markdown
Owner Author

msosyak commented Jul 15, 2021

I will dry run the changes and run some tests on this. and update here

@msosyak
Copy link
Copy Markdown
Owner Author

msosyak commented Jul 20, 2021

Faced an issue when trying to build docker-ptf as it's dependent on libsai but it is also deb9 based so the build failed due to dependencies issue. But syncd-rpc works well with old docker ptf

@msosyak msosyak closed this Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant