Additions to ext type support for JRuby #92
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a hard time explaining what I though must be changed in #91 so I made the changes myself.
Unfortunately the tests don't pass in this branch,
Factory#registered_types_internal,Packer#registered_types_internalandUnpacker#registered_types_internalhave inconsistent interfaces. The consumers of these methods expect slightly different things in the returned values. This seems to be a consequence of the aforementioned design decision in the C implementation, and I consider it a bug. I can't fix it without changing the C code and the design, something I'm not comfortable doing.@tagomoris this is how I think the JRuby implementation should work, but as I mentioned it requires changes to the C implementation. It's up to you to decide how to proceed.