Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Aug 29, 2025

Fixes #31777

Description

Fix scissor value bound check, supporting RenderTarget and fixed RenderContext.(width/height) which could have an uninitialized value.

@sunag sunag added this to the r180 milestone Aug 29, 2025
@sunag sunag marked this pull request as ready for review August 29, 2025 04:58
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.91
79.11
338.91
79.11
+0 B
+0 B
WebGPU 579.36
159.65
579.35
159.66
-6 B
+9 B
WebGPU Nodes 577.97
159.4
577.96
159.41
-6 B
+10 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 470.78
113.9
470.78
113.9
+0 B
+0 B
WebGPU 649.51
175.52
649.5
175.53
-6 B
+9 B
WebGPU Nodes 603.6
164.66
603.6
164.67
-6 B
+9 B

@sunag sunag merged commit cde2d20 into mrdoob:dev Aug 29, 2025
9 checks passed
@sunag sunag deleted the dev-fix-scissor-v branch August 29, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPURenderer: Setting scissor test can break PMREM

1 participant