-
-
Notifications
You must be signed in to change notification settings - Fork 36.1k
WebGPUBackend: Align frontFace and cullMode values to WebGL backend.
#31769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
|
/ping @sunag This PR causes breakage, and I would advise against changing the winding order convention at this late hour prior to a release. TBH, I would prefer to continue with the convention @sunag established with // For example, consider the following color node when rendering transparent, double-sided materials: material.colorNode = select( frontFacing, color( 0xff0000 ), color( 0x0000ff ) );With this PR, the back faces will have the same color as the front faces. Transparent, double-sided materials render in two passes, with front faces and back faces rendered separately. |
|
Yes, the PR brings other implications. We can revert it and bring a more robust solution in the next release. |
…ackend. (mrdoob#31769)" This reverts commit fd74f49.
|
Agreed! Thanks for reverting. But should when then consider to align the WebGL backend to the WebGPU one? Using negative scaling is currently broken as highlighted in #31764. Having at least a consistent response of both backends seems preferable to me. |
@Mugen87 Yes, that sounds like a very good idea. But be particularly careful in testing bump mapping, which uses |
Fixed #31764.
Description
The PR makes sure the WebGPU backend implements the render pipeline values for
frontFaceandcullModelike in WebGL backend.