WebGPURenderer: Fix timestamp query conflict #31762
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #30359
Description
The simple id checks by
RenderContextorComputeNodecould conflict with each other, with the main problem being in theRenderContextcache when used in the same frame. This PR adds a more robust UID fixing this bug.To reproduce this bug you can just duplicate the number of
renderer.compute( a )calls — the result of the sum will always be the same.Open
webgpu_compute_particles_snowand add:The compute graph (CPT) is the most important one in this example.
It’s possible to notice the problem as well when the RenderContext is shared, as in Gaussian blur, where only a single render call is considered.