WebGPURenderer: Add support for manual mipmaps for cube maps. #31639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
commented
Aug 13, 2025
| // Normal textures and compressed cube textures define base level + mips with their mipmap array | ||
| // Uncompressed cube textures use their mipmap array only for mips (no base level) | ||
|
|
||
| if ( texture.isCubeTexture && texture.mipmaps.length > 0 ) options.levels ++; |
There was a problem hiding this comment.
Side note: At some point we should treat mipmap definitions uniformly for all texture types in both renderers. This will be a breaking change though and best done with a separate PR. But first we need to settle on just one of the existing policies: The one we use for regular and compressed textures or the one for cube maps.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31637
Description
Same as #31637 but now for
CubeTexture. A new examplewebgpu_materials_cubemap_mipmaps(a port of a WebGL example) is added to test the new code path.