Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Aug 12, 2025

Fixed #31631.

Description

The WebGPU backend must not share node builder states when sampler data of render objects mismatch.

Render objects that share the node builder state also share the same bindings which is the root cause of #31631.

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.9
79.1
338.9
79.1
+0 B
+0 B
WebGPU 570.33
157.5
570.44
157.54
+108 B
+40 B
WebGPU Nodes 568.94
157.26
569.05
157.3
+108 B
+39 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 470.64
113.87
470.64
113.87
+0 B
+0 B
WebGPU 643.16
173.92
643.27
173.96
+108 B
+43 B
WebGPU Nodes 597.34
163.12
597.45
163.16
+108 B
+41 B

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Aug 13, 2025

I'll go ahead and merge so I can move on with fixing the missing manual mipmaps support.

@Mugen87 Mugen87 merged commit f0a5bf9 into mrdoob:dev Aug 13, 2025
13 of 14 checks passed
@Mugen87 Mugen87 added this to the r180 milestone Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WebGPUBackend: Textures are not always filtered correctly.

1 participant