Rename RGBELoader to HDRLoader #31604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages/docs, and adjust HDRCubeTextureLoader to depend on HDRLoader
Mugen87
reviewed
Aug 8, 2025
|
Can we keep It was okay to directly remove Edit: I've seen you already changed it 👍 . |
|
Btw, GPT5 did a decent job but took way too long. I feel like Claude Sonnet/Opus is still better/faster. |
This was referenced Aug 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At this point
HDRLoaderseems like a better name for the loader thanRGBELoaderso I asked GPT-5 to give it a go 😇/cc @WestLangley