Skip to content

Conversation

@NoxDawnsong
Copy link
Contributor

Description

The default render-target for the reflector-node had no option to set anti-aliasing samples. For reflectors covering a large range, this can lead to unwanted flickering on distant and/or small objects, especially when using further processing on the reflector such as simulating roughness via blurring.

This PR adds a sample-parameter to the reflector to mitigate this.

As the constructor-signature of this node changed, the Typescript-definition package probably would need an update as well.

@NoxDawnsong NoxDawnsong changed the title Add AA-samples parameter to reflector-node TSL: Add AA-samples parameter to reflector-node Jul 31, 2025
@github-actions
Copy link

github-actions bot commented Jul 31, 2025

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 338.84
79.07
338.84
79.07
+0 B
+0 B
WebGPU 566.16
156.5
566.21
156.52
+48 B
+16 B
WebGPU Nodes 564.77
156.26
564.81
156.28
+48 B
+16 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 470.26
113.77
470.26
113.77
+0 B
+0 B
WebGPU 637.36
172.49
637.36
172.49
+0 B
+0 B
WebGPU Nodes 592.01
161.73
592.01
161.73
+0 B
+0 B

@NoxDawnsong NoxDawnsong marked this pull request as ready for review August 1, 2025 18:04
@NoxDawnsong
Copy link
Contributor Author

Requires #31544 in order to avoid blank RT when specifying both MSAA and mipmaps.

@Mugen87 Mugen87 added this to the r180 milestone Aug 2, 2025
@Mugen87 Mugen87 merged commit ac6a8e0 into mrdoob:dev Aug 2, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants