SceneOptimizer: Fix toBatchedMesh() Materials #29935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RenaudRohlinger
approved these changes
Nov 20, 2024
Collaborator
|
Thanks! |
RenaudRohlinger
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While playing with the sceneOptimizer I noticed that it didn't check for the map property when generating the mapHash, which would cause some incompatible mesh to be batched together.
Regarding the material, they were all converted to physicalMaterial, now they use the same constructor as the original material.
And lastly, regarding the color, it was both on the initial material and per instance resulting in different color than the originals.
This contribution is funded by Alaric Baraou💶