OrbitControl: Fixed rotation toggle in KeyDown handler #29834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented the toggle via `enableRotate` also on `_handleKeyDown`. The previous behaviour seemed unexpected, allowing rotation via keys, even when rotating should be disabled if `enableRotate` was set to `false`.
i3ene
changed the title
Refactor `enablePan` in `_handleKeyDown()`.
Correctly set `needsUpdate` in `_handleKeyDown()`.
Collaborator
|
I've slightly refactored the PR to handle |
Revert `needsUpdate` change.
Mugen87
added a commit
that referenced
this pull request
Nov 12, 2024
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the toggle via
enableRotatealso on_handleKeyDown. The previous behaviour seemed unexpected, allowing rotation via keys, even when rotating should be disabled ifenableRotatewas set tofalse.Description
The previous implementation of
_handleKeyDowndid not take theenableRotatestate into account. This seemed unexpected whenenableRotatewas set tofalse, but rotation was still possible with key events.This commit guards the rotation of the
keydownevent additionally with the already availableenableRotatevariable and makes it more intuitive in its behavior again.