Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Oct 9, 2024

Related issue: #29595 (comment)

Description

Improve names, replaced some save to reset

@sunag sunag added this to the r170 milestone Oct 9, 2024
@github-actions
Copy link

github-actions bot commented Oct 9, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 689.82
170.9
689.82
170.9
+0 B
+0 B
WebGPU 811.49
218.59
811.5
218.59
+10 B
+5 B
WebGPU Nodes 811
218.46
811.01
218.47
+10 B
+5 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 462.84
111.78
462.84
111.78
+0 B
+0 B
WebGPU 535.71
144.58
535.71
144.58
+0 B
+0 B
WebGPU Nodes 491.83
134.32
491.83
134.32
+0 B
+0 B

@Mugen87
Copy link
Collaborator

Mugen87 commented Oct 9, 2024

We now might want to honor SSRNode in this PR^^.

@sunag sunag marked this pull request as ready for review October 9, 2024 18:51
@sunag sunag merged commit 1d91b42 into mrdoob:dev Oct 9, 2024
12 checks passed
@sunag sunag deleted the dev-pp-name branch October 9, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants