Skip to content

Conversation

@cmhhelgeson
Copy link
Contributor

Description

StorageArrayElementNode will query its parent node for it's .instanceIndex property, which doesn't appear to be an existing property or get method.

@github-actions
Copy link

github-actions bot commented Aug 30, 2024

📦 Bundle size

Full ESM build, minified and gzipped.

Before After Diff
WebGL 685.18
169.62
685.18
169.62
+0 B
+0 B
WebGPU 826.02
221.46
825.96
221.44
-66 B
-19 B
WebGPU Nodes 825.61
221.36
825.54
221.34
-66 B
-19 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Before After Diff
WebGL 461.96
111.46
461.96
111.46
+0 B
+0 B
WebGPU 525.27
141.52
525.27
141.52
+0 B
+0 B
WebGPU Nodes 481.93
131.34
481.93
131.34
+0 B
+0 B

@cmhhelgeson
Copy link
Contributor Author

Should node.instanceIndex just be replaced with node.isIndexNode?

@mrdoob mrdoob requested a review from sunag September 5, 2024 07:34
@sunag sunag added this to the r169 milestone Sep 5, 2024
@sunag sunag merged commit 0bf5f09 into mrdoob:dev Sep 5, 2024
@cmhhelgeson cmhhelgeson deleted the remove_dot_instanceIndex branch September 6, 2024 04:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants