Skip to content

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Aug 29, 2024

Related issue: #29257 (comment)

Description

Fix view dimension if shared the property.

@sunag sunag added this to the r168 milestone Aug 29, 2024
@sunag sunag marked this pull request as ready for review August 29, 2024 23:00
@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
WebGLRenderer 685.4 kB (169.7 kB) 685.4 kB (169.7 kB) +0 B
WebGPURenderer 818.7 kB (221.3 kB) 818.7 kB (221.3 kB) +39 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
WebGLRenderer 462 kB (111.4 kB) 462 kB (111.4 kB) +0 B
WebGPURenderer 564.9 kB (153.4 kB) 564.9 kB (153.4 kB) +39 B

@sunag sunag merged commit 54e591c into mrdoob:dev Aug 29, 2024
@sunag sunag deleted the dev-fix-example branch August 29, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant