OrbitControls: Derive from Controls.
#29142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Just a note, these kinds of changes (every line of the file has changed) unfortunately make it really hard to rebase changes in a fork to the latest three.js version... |
Collaborator
Author
|
Unfortunately, there is no way around the refactoring which was long overdue. We must make the files more ES6 conform if we want to use ESNext features (like private fields and methods) in the future. Besides, code consistency is important as well. It's easier to maintain the controls if they follow the same principles (similar to loaders). |
This was referenced Aug 25, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29085
Description
Same as #29085.
To clarify, this PR does not change any parts of the public API or behavior of
OrbitControls. The class is now derived fromControlsand implemented in a ES6 style like all other controls. The constructor can be side-effect free if nodomElementis assigned to the ctor. WhendomElementis assigned after construction time, the app has to callcontrols.connect()once.