Skip to content

WebGPURenderer: Avoid using proxy in rendering cycle #29094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2024
Merged

WebGPURenderer: Avoid using proxy in rendering cycle #29094

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d39fdb
fix import path
sunag Aug 9, 2024
2157061
avoid using proxy in rendering cycle
sunag Aug 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/nodes/accessors/ReferenceNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ class ReferenceNode extends Node {

}

this.node = node;
this.node = node.getSelf();

}

Expand Down
15 changes: 7 additions & 8 deletions src/nodes/accessors/TextureNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ class TextureNode extends UniformNode {

const textureNode = this.clone();
textureNode.uvNode = nodeObject( uvNode );
textureNode.referenceNode = this;
textureNode.referenceNode = this.getSelf();

return nodeObject( textureNode );

Expand All @@ -317,7 +317,7 @@ class TextureNode extends UniformNode {

const textureNode = this.clone();
textureNode.biasNode = nodeObject( amountNode ).mul( maxMipLevel( textureNode ) );
textureNode.referenceNode = this;
textureNode.referenceNode = this.getSelf();

return nodeObject( textureNode );

Expand All @@ -327,7 +327,7 @@ class TextureNode extends UniformNode {

const textureNode = this.clone();
textureNode.levelNode = nodeObject( levelNode );
textureNode.referenceNode = this;
textureNode.referenceNode = this.getSelf();

return nodeObject( textureNode );

Expand All @@ -343,7 +343,7 @@ class TextureNode extends UniformNode {

const textureNode = this.clone();
textureNode.biasNode = nodeObject( biasNode );
textureNode.referenceNode = this;
textureNode.referenceNode = this.getSelf();

return nodeObject( textureNode );

Expand All @@ -353,7 +353,7 @@ class TextureNode extends UniformNode {

const textureNode = this.clone();
textureNode.compareNode = nodeObject( compareNode );
textureNode.referenceNode = this;
textureNode.referenceNode = this.getSelf();

return nodeObject( textureNode );

Expand All @@ -363,8 +363,7 @@ class TextureNode extends UniformNode {

const textureNode = this.clone();
textureNode.gradNode = [ nodeObject( gradNodeX ), nodeObject( gradNodeY ) ];

textureNode.referenceNode = this;
textureNode.referenceNode = this.getSelf();

return nodeObject( textureNode );

Expand All @@ -374,7 +373,7 @@ class TextureNode extends UniformNode {

const textureNode = this.clone();
textureNode.depthNode = nodeObject( depthNode );
textureNode.referenceNode = this;
textureNode.referenceNode = this.getSelf();

return nodeObject( textureNode );

Expand Down
2 changes: 1 addition & 1 deletion src/nodes/utils/CubeMapNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { nodeProxy } from '../shadernode/ShaderNode.js';
import { CubeTexture } from '../../textures/CubeTexture.js';
import { cubeTexture } from '../accessors/CubeTextureNode.js';
import CubeRenderTarget from '../../renderers/common/CubeRenderTarget.js';
import { CubeReflectionMapping, CubeRefractionMapping, EquirectangularReflectionMapping, EquirectangularRefractionMapping } from '../../constants';
import { CubeReflectionMapping, CubeRefractionMapping, EquirectangularReflectionMapping, EquirectangularRefractionMapping } from '../../constants.js';

const _cache = new WeakMap();

Expand Down