Skip to content

Conversation

@Mugen87
Copy link
Collaborator

@Mugen87 Mugen87 commented Jul 27, 2024

Fixed #28995.

Description

The deprecated color space conversion functions were removed last release via #28901. Unfortunately, TextureUtils which is used by GLTFExporter still relied on the old code.

This PR renames LinearTosRGB() to sRGBTransferOETF().

@Mugen87 Mugen87 added this to the r168 milestone Jul 27, 2024
@Mugen87 Mugen87 merged commit d906b25 into mrdoob:dev Jul 27, 2024
brunosimon pushed a commit to brunosimon/three.js that referenced this pull request Jul 28, 2024
@mrdoob
Copy link
Owner

mrdoob commented Jul 29, 2024

Does this deserve a 0.167.1?

@Mugen87
Copy link
Collaborator Author

Mugen87 commented Jul 29, 2024

Yeah, probably good to move this into production.

mrdoob pushed a commit that referenced this pull request Aug 1, 2024
@mrdoob
Copy link
Owner

mrdoob commented Aug 1, 2024

Done!

mrdoob pushed a commit that referenced this pull request Aug 1, 2024
@Mugen87 Mugen87 modified the milestones: r168, r167 Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GLTFExport + KTX textures issue

2 participants