Core: Add Matrix2 class #28923
Merged
Core: Add Matrix2 class #28923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Jul 20, 2024
Mugen87
reviewed
Jul 20, 2024
| @@ -0,0 +1,54 @@ | |||
| export class Matrix2 { | |||
Collaborator
There was a problem hiding this comment.
Should we move this class to the core instead?
Collaborator
Author
There was a problem hiding this comment.
I'll leave that up to someone else to decide. With tree shaking I suppose it's not a big deal to move but I'm not sure of what the exact rules are for what belongs in examples vs core.
Collaborator
There was a problem hiding this comment.
It's a case by case decision but since Vector2 is part of the core it seems more consistent to add Matrix2 as well.
Collaborator
Author
There was a problem hiding this comment.
Okay - I can move it if you'd like!
Collaborator
Author
There was a problem hiding this comment.
Great - I've just moved the files to core
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Jul 20, 2024
| export { Ray } from './math/Ray.js'; | ||
| export { Matrix4 } from './math/Matrix4.js'; | ||
| export { Matrix3 } from './math/Matrix3.js'; | ||
| export { Matrix2 } from './math/Matrix2.js'; |
Collaborator
There was a problem hiding this comment.
Do you mind also adding the entry for Three.WebGPU.js?
Otherwise the WebGPU build won't have this class.
Mugen87
approved these changes
Jul 21, 2024
This was referenced Jul 23, 2024
repalash
added a commit
to repalash/three.js
that referenced
this pull request
Jul 24, 2025
dbuck
pushed a commit
to matterport/3DTilesRendererJS
that referenced
this pull request
Nov 12, 2025
v167 is when Matrix2 shipped mrdoob/three.js#28923 I noticed while updating a local example build, but wanted to update in the smallest chunk required to test, updating to 166 per the peer deps results in the error below. ``` ✘ [ERROR] No matching export in "node_modules/three/build/three.module.js" for import "Matrix2" node_modules/3d-tiles-renderer/build/WMSCapabilitiesLoader-j6h8dwK_.js:3:434: 3 │ ...Triangle as Ht, Vector4 as Ue, Matrix4 as Q, Matrix3 as kn, Matrix2 as jn, WebGLRenderer as zn, WebGLRenderTarget as Ut, Shade... ╵ ```
dbuck
pushed a commit
to matterport/3DTilesRendererJS
that referenced
this pull request
Nov 12, 2025
v167 is when Matrix2 shipped mrdoob/three.js#28923 I noticed while updating a local example build, but wanted to update in the smallest chunk required to test, updating to 166 per the peer deps results in the error below. ``` ✘ [ERROR] No matching export in "node_modules/three/build/three.module.js" for import "Matrix2" node_modules/3d-tiles-renderer/build/WMSCapabilitiesLoader-j6h8dwK_.js:3:434: 3 │ ...Triangle as Ht, Vector4 as Ue, Matrix4 as Q, Matrix3 as kn, Matrix2 as jn, WebGLRenderer as zn, WebGLRenderTarget as Ut, Shade... ╵ ```
gkjohnson
pushed a commit
to NASA-AMMOS/3DTilesRendererJS
that referenced
this pull request
Nov 13, 2025
v167 is when Matrix2 shipped mrdoob/three.js#28923 I noticed while updating a local example build, but wanted to update in the smallest chunk required to test, updating to 166 per the peer deps results in the error below. ``` ✘ [ERROR] No matching export in "node_modules/three/build/three.module.js" for import "Matrix2" node_modules/3d-tiles-renderer/build/WMSCapabilitiesLoader-j6h8dwK_.js:3:434: 3 │ ...Triangle as Ht, Vector4 as Ue, Matrix4 as Q, Matrix3 as kn, Matrix2 as jn, WebGLRenderer as zn, WebGLRenderTarget as Ut, Shade... ╵ ``` Co-authored-by: Dave Buchhofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: --
Description
GLSL, Three.js BufferAttributes, and GLTF accessors support 2x2 matrix types so it may be nice to make a basic Matrix2 class available in three so these types can be used and manipulated more easily. This class was originally created for the 3DTilesRendererJS project (see here) for use with the GLTF EXT_structural_metadata extension so data could be read from mat2 buffer accessors and returned in a format similar to Matrix3 and Matrix4.
Only the functions needed for the initial implementation are included here. More can be added by the community over time as needed.
This contribution is funded by Cesium GIS Ecosystem Grant