USDZLoader: throw error instead of warning #28685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
USDZLoader should throw an error instead of the warning, to allow the consumer to act upon the error.
Mugen87
approved these changes
Jun 17, 2024
Mugen87
reviewed
Jun 17, 2024
|
|
||
| console.warn( 'THREE.USDZLoader: Crate files (.usdc or binary .usd) are not supported.' ); | ||
| continue; | ||
| throw Error( 'THREE.USDZLoader: Crate files (.usdc or binary .usd) are not supported.' ); |
Collaborator
There was a problem hiding this comment.
Yeah, I think throwing an error is indeed more helpful than just logging a warning. In this way, the app can better handle the situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #28684
Description
USDZLoader should throw an error instead of the warning, to allow the consumer to act upon the error. This PR changes the console warnings to throw errors, and removes the block that returns an empty group when findUSD returns undefined.