WebGPURenderer: fix rendering to depth textures with multiple color attachments (MRT - WGSL) #28523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aardgoose
changed the title
sunag
reviewed
May 29, 2024
Contributor
|
I just tested the changes locally in my app. That works, with this changes the depthNode works in conjunction with the outputNode like with the colorNode. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: Closes #28519
Rendering using outputStruct() to multiple render targets doesn't handle depth with WGSL because @Builtin('frag_depth') not included in the output struct definition. (GLSL unaffected).
Include builtins as required and simplify, avoiding the var in main fragment shader function and aligning with standard code with the output named 'output'.