WebGPURenderer: Add aoNode to NodeMaterial
#28061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@Mugen87 CI seems to break because of |
sunag
approved these changes
Apr 3, 2024
Collaborator
|
see #28051 (comment) Alternatively, can you try to regenerate the screenshot? |
Collaborator
Author
|
Unfortunately I believe that we do share the same device (Macbook Pro M1 Max). 😄 |
Collaborator
|
I'll try it later on a Windows notebook. Let's ignore the failure for now... |
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the possibility to override the
ambientOcclusionnode of a material.This contribution is funded by Utsubo