THREE.TextGeometry: .height -> .depth
#27949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- depreciating `height` parameter in TextGeometry options for `depth` for consistency with ExtrudeGeometry, which refers to the thickness the Text will be extruded. using `height` is still supported but will emit a warning in the console - updated examples, manual and docs
Mugen87
approved these changes
Mar 20, 2024
This was referenced Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting out api changes of { height } -> { depth } from Editor Text's PR to this, where examples and documentation is updated to reflect the new parameters. I've ran most if not all the files that referenced TextGeometry (surprisingly more than just a handful of files) and check that the examples no longer print the depreciated console warnings.
Related issue: #27931
Description
heightparameter in TextGeometry options fordepthfor consistency with ExtrudeGeometry, which refers to the thickness the Text will be extruded. usingheightis still supported but will emit a warning in the console