Nodes: Log warnings instead of throwing on redefinitions of Node types #27357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the same behaviour as three.js itself has when it's imported multiple times.
AdaRoseCannon
pushed a commit
to AdaRoseCannon/three.js
that referenced
this pull request
Jan 15, 2024
mrdoob#27357) This is the same behaviour as three.js itself has when it's imported multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, when multiple versions of three are used (which is almost always accidental, yet can happen for example when using browser extensions that bring their own version of three.js), using Nodes leads to exceptions.
This PR downgrades those to warnings.
This is the same behaviour as three.js itself has when it's imported multiple times:
three.js/src/Three.js
Line 176 in ca7261b
This contribution is funded by Needle