Skip to content

WebGLUniforms: Add sampler2DShadow support. #27252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 30, 2023
Merged

WebGLUniforms: Add sampler2DShadow support. #27252

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7be9c74
add support for sampler2DShadow in uniforms
RenaudRohlinger Nov 27, 2023
27a5023
Update WebGLUniforms.js
mrdoob Nov 28, 2023
d9fe5c2
use gl.SAMPLER_2D_SHADOW instead
RenaudRohlinger Nov 30, 2023
c417c80
Update WebGLUniforms.js
mrdoob Nov 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/renderers/webgl/WebGLUniforms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,14 @@ import { CubeTexture } from '../../textures/CubeTexture.js';
import { Texture } from '../../textures/Texture.js';
import { DataArrayTexture } from '../../textures/DataArrayTexture.js';
import { Data3DTexture } from '../../textures/Data3DTexture.js';
import { DepthTexture } from '../../textures/DepthTexture.js';
import { LessEqualCompare } from '../../constants.js';

const emptyTexture = /*@__PURE__*/ new Texture();

const emptyShadowTexture = /*@__PURE__*/ new DepthTexture( 1, 1 );
emptyShadowTexture.compareFunction = LessEqualCompare;

const emptyArrayTexture = /*@__PURE__*/ new DataArrayTexture();
const empty3dTexture = /*@__PURE__*/ new Data3DTexture();
const emptyCubeTexture = /*@__PURE__*/ new CubeTexture();
Expand Down Expand Up @@ -563,7 +569,9 @@ function setValueT1( gl, v, textures ) {

}

textures.setTexture2D( v || emptyTexture, unit );
const emptyTexture2D = ( this.type === gl.SAMPLER_2D_SHADOW ) ? emptyShadowTexture : emptyTexture;

textures.setTexture2D( v || emptyTexture2D, unit );

}

Expand Down Expand Up @@ -947,6 +955,7 @@ class SingleUniform {
this.id = id;
this.addr = addr;
this.cache = [];
this.type = activeInfo.type;
this.setValue = getSingularSetter( activeInfo.type );

// this.path = activeInfo.name; // DEBUG
Expand All @@ -962,6 +971,7 @@ class PureArrayUniform {
this.id = id;
this.addr = addr;
this.cache = [];
this.type = activeInfo.type;
this.size = activeInfo.size;
this.setValue = getPureArraySetter( activeInfo.type );

Expand Down