Skip to content

TextureNode: .forceUVContext #27031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2023
Merged

TextureNode: .forceUVContext #27031

merged 1 commit into from
Oct 23, 2023

Conversation

@sunag
Copy link
Collaborator

@sunag sunag commented Oct 23, 2023

Related issue: #26848 (comment)

Description

Force replacement of UVNode if the context includes forceUVContext=true.

@sunag sunag added this to the r158 milestone Oct 23, 2023
@sunag
Copy link
Collaborator Author

sunag commented Oct 23, 2023 •
edited
Loading

@njarraud That should fix it.

Usage:

const texNode = texture( map, uv( 1 ) );

bumpMap( texNode, 1.0 );

@sunag sunag marked this pull request as ready for review October 23, 2023 00:07
@sunag sunag merged commit 0a612e3 into mrdoob:dev Oct 23, 2023
@sunag sunag deleted the dev-forceUVContext branch October 23, 2023 03:45
CITIZENDOT pushed a commit to CITIZENDOT/three.js that referenced this pull request Oct 25, 2023
@sunag @CITIZENDOT
TextureNode: forceUVContext (mrdoob#27031)
3f12524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r158

Development

Successfully merging this pull request may close these issues.

1 participant

@sunag