Skip to content

WebGPURenderer: Render Pass ID and Double Pass #26333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 28, 2023
Merged

WebGPURenderer: Render Pass ID and Double Pass #26333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb95ad5
WebGPURenderer: NS RenderObject and Double Pass
sunag Jun 27, 2023
b10c081
Example `webgpu_backdrop_area`: Move to DoubleSide
sunag Jun 27, 2023
febcbfb
namespace to pass id
sunag Jun 27, 2023
aec22f1
namespace -> passId
sunag Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 21 additions & 14 deletions examples/jsm/renderers/common/RenderObjects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,33 +2,33 @@ import DataMap from './DataMap.js';
import ChainMap from './ChainMap.js';
import RenderObject from './RenderObject.js';

class RenderObjects extends ChainMap {
class RenderObjects {

constructor( renderer, nodes, geometries, pipelines, info ) {

super();

this.renderer = renderer;
this.nodes = nodes;
this.geometries = geometries;
this.pipelines = pipelines;
this.info = info;

this.chainMaps = {};
this.dataMap = new DataMap();

}

get( object, material, scene, camera, lightsNode ) {
get( object, material, scene, camera, lightsNode, passId ) {

const chainMap = this.getChainMap( passId );
const chainArray = [ object, material, scene, camera, lightsNode ];

let renderObject = super.get( chainArray );
let renderObject = chainMap.get( chainArray );

if ( renderObject === undefined ) {

renderObject = this.createRenderObject( this.nodes, this.geometries, this.renderer, object, material, scene, camera, lightsNode );
renderObject = this.createRenderObject( this.nodes, this.geometries, this.renderer, object, material, scene, camera, lightsNode, passId );

this.set( chainArray, renderObject );
chainMap.set( chainArray, renderObject );

} else {

Expand All @@ -49,29 +49,36 @@ class RenderObjects extends ChainMap {

}

dispose() {
getChainMap( passId = 'default' ) {

super.dispose();
return this.chainMaps[ passId ] || ( this.chainMaps[ passId ] = new ChainMap() );

}

this.dataMap.clear();
dispose() {

this.chainMaps = {};
this.dataMap = new DataMap();

}

createRenderObject( nodes, geometries, renderer, object, material, scene, camera, lightsNode ) {
createRenderObject( nodes, geometries, renderer, object, material, scene, camera, lightsNode, passId ) {

const chainMap = this.getChainMap( passId );
const dataMap = this.dataMap;
const renderObject = new RenderObject( nodes, geometries, renderer, object, material, scene, camera, lightsNode );

const data = this.dataMap.get( renderObject );
const data = dataMap.get( renderObject );
data.cacheKey = renderObject.getCacheKey();

renderObject.onDispose = () => {

this.dataMap.delete( renderObject );
dataMap.delete( renderObject );

this.pipelines.delete( renderObject );
this.nodes.delete( renderObject );

this.delete( renderObject.getChainArray() );
chainMap.delete( renderObject.getChainArray() );

};

Expand Down
42 changes: 36 additions & 6 deletions examples/jsm/renderers/common/Renderer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import RenderContexts from './RenderContexts.js';
import Textures from './Textures.js';
import Background from './Background.js';
import Nodes from './nodes/Nodes.js';
import { Frustum, Matrix4, Vector2, Vector3, Vector4, Color, SRGBColorSpace, NoToneMapping } from 'three';
import { Frustum, Matrix4, Vector2, Vector3, Vector4, Color, DoubleSide, BackSide, FrontSide, SRGBColorSpace, NoToneMapping } from 'three';

const _drawingBufferSize = new Vector2();
const _screen = new Vector4();
Expand Down Expand Up @@ -805,17 +805,47 @@ class Renderer {

//

const renderObject = this._objects.get( object, material, scene, camera, lightsNode );
renderObject.context = this._currentRenderContext;
object.modelViewMatrix.multiplyMatrices( camera.matrixWorldInverse, object.matrixWorld );
object.normalMatrix.getNormalMatrix( object.modelViewMatrix );

//

this._nodes.updateBefore( renderObject );
material.onBeforeRender( this, scene, camera, geometry, material, group );

//

object.modelViewMatrix.multiplyMatrices( camera.matrixWorldInverse, object.matrixWorld );
object.normalMatrix.getNormalMatrix( object.modelViewMatrix );
if ( material.transparent === true && material.side === DoubleSide && material.forceSinglePass === false ) {

material.side = BackSide;
this._renderObjectDirect( object, scene, camera, geometry, material, group, lightsNode, 'backSide' ); // create backSide pass id

material.side = FrontSide;
this._renderObjectDirect( object, scene, camera, geometry, material, group, lightsNode ); // use default pass id

material.side = DoubleSide;

} else {

this._renderObjectDirect( object, scene, camera, geometry, material, group, lightsNode );
Copy link
Contributor

@LeviPesin LeviPesin Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should here also use frontSide or backSide namespace depending on material side? Not sure if I understood the namespaces approach correctly...

Copy link
Collaborator Author

@sunag sunag Jun 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Namespace can cause confusion, I renamed the term to pass id, seems more appropriate. It is compared with a parameter in chain map to get a unique RenderObject:

const renderObject = this._objects.get( object, material, scene, camera, lightsNode, passId )

...

return chainMaps[ passId ].get( object, material, scene, camera, lightsNode );


}

//

object.onAfterRender( this, scene, camera, geometry, material, group );

}

_renderObjectDirect( object, scene, camera, geometry, material, group, lightsNode, passId ) {

//

const renderObject = this._objects.get( object, material, scene, camera, lightsNode, passId );
renderObject.context = this._currentRenderContext;

//

this._nodes.updateBefore( renderObject );

//

Expand Down
17 changes: 6 additions & 11 deletions examples/webgpu_backdrop_area.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,16 +86,19 @@
volumeMaterial.backdropNode = viewportSharedTexture();
volumeMaterial.backdropAlphaNode = depthAlphaNode;
volumeMaterial.transparent = true;
volumeMaterial.side = THREE.DoubleSide;

const depthMaterial = new MeshBasicNodeMaterial();
depthMaterial.backdropNode = depthAlphaNode;
depthMaterial.transparent = true;
depthMaterial.side = THREE.DoubleSide;

const bicubicMaterial = new MeshBasicNodeMaterial();
bicubicMaterial.backdropNode = viewportMipTexture().bicubic( 5 ); // @TODO: Move to alpha value [ 0, 1 ]
bicubicMaterial.backdropAlphaNode = checker( uv().mul( 3 ).mul( modelScale.xy ) );
bicubicMaterial.opacityNode = bicubicMaterial.backdropAlphaNode;
bicubicMaterial.transparent = true;
bicubicMaterial.side = THREE.DoubleSide;

const pixelMaterial = new MeshBasicNodeMaterial();
pixelMaterial.backdropNode = viewportSharedTexture( viewportTopLeft.mul( 100 ).floor().div( 100 ) );
Expand All @@ -105,15 +108,8 @@

const box = new THREE.Mesh( new THREE.BoxGeometry( 2, 2, 2 ), volumeMaterial );
box.position.set( 0, 1, 0 );
//box.material.side = THREE.DoubleSide; // @TODO: Needed add support to material.forceSinglePass = false;
scene.add( box );

const boxBack = new THREE.Mesh( new THREE.BoxGeometry( 2, 2, 2 ).scale( - 1, - 1, - 1 ), volumeMaterial );
boxBack.position.set( 0, 1, 0 );
boxBack.renderOrder = - 1;
boxBack.visible = false;
scene.add( boxBack );

const floor = new THREE.Mesh( new THREE.BoxGeometry( 1.99, .01, 1.99 ), new MeshBasicNodeMaterial( { color: 0x333333 } ) );
floor.position.set( 0, 0, 0 );
scene.add( floor );
Expand Down Expand Up @@ -146,12 +142,11 @@
const gui = new GUI();
const options = { material: 'volume' };

gui.add( box.scale, 'x', 0.1, 2, 0.01 ).onChange( () => boxBack.scale.copy( box.scale ) );
gui.add( box.scale, 'z', 0.1, 2, 0.01 ).onChange( () => boxBack.scale.copy( box.scale ) );
gui.add( box.scale, 'x', 0.1, 2, 0.01 );
gui.add( box.scale, 'z', 0.1, 2, 0.01 );
gui.add( options, 'material', Object.keys( materials ) ).onChange( name => {

box.material = boxBack.material = materials[ name ];
boxBack.visible = ( name === 'bicubic' );
box.material = materials[ name ];

} );

Expand Down