Skip to content

Conversation

@WestLangley
Copy link
Collaborator

@WestLangley WestLangley commented May 25, 2023

This is an exposure-only pass. Useful for rendering HDR output to an archive EXR in working color space, for example.

As suggested in #26130 (comment).

@WestLangley WestLangley added this to the r153 milestone May 25, 2023
@mrdoob
Copy link
Owner

mrdoob commented May 26, 2023

Hmm, actually... Wouldn't it make sense to do this also in the OutputPass?

@WestLangley
Copy link
Collaborator Author

@mrdoob Can you please explain what you are referring to?

@mrdoob
Copy link
Owner

mrdoob commented May 26, 2023

Oh, actually... Never mind, I misunderstood.

@mrdoob mrdoob merged commit 183295e into mrdoob:dev May 26, 2023
@mrdoob
Copy link
Owner

mrdoob commented May 26, 2023

No wait...

Wouldn't it be better to hide this for the developer in OutputPass?

Ideally the developer wouldn't have to have two different code paths (One for HDR and another for non-HDR).
They would just use OutputPass. And OutputPass would do toneMapping only in non-HDR displays.

@WestLangley
Copy link
Collaborator Author

This is separate from OutputPass, which is device-specific.

This is an exposure-only pass. Useful for rendering HDR output to an archive EXR in working color space, for example.

@WestLangley WestLangley deleted the dev-exposure_shader branch May 26, 2023 12:42
@mrdoob
Copy link
Owner

mrdoob commented May 26, 2023

Ah okay... Makes sense.

I think I didn't understand the exact use case for this PR by reading the conversation #26130.

I'll update your PR description for clarity in case we have to look at this PR again in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants