Skip to content

Conversation

@makc
Copy link
Contributor

@makc makc commented May 12, 2023

Fixed #26038.

As discussed with @Mugen87

Docs might need human proof-reading (I only checked with googel translate)

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize dev Filesize PR Diff
642.6 kB (159.1 kB) 642.6 kB (159.1 kB) +60 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize dev Filesize PR Diff
432.4 kB (104.7 kB) 432.5 kB (104.8 kB) +60 B

@Mugen87 Mugen87 added this to the r153 milestone May 13, 2023
@Mugen87 Mugen87 changed the title make Matrix4.makeTranslation accept Vector3 Matrix4: Make makeTranslation() accept Vector3. May 13, 2023
@Mugen87 Mugen87 merged commit 2813196 into mrdoob:dev May 13, 2023
@makc makc deleted the matrix4-patch branch May 13, 2023 15:06
@Methuselah96 Methuselah96 mentioned this pull request Jun 4, 2023
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make Matrix4.makeTranslation accept Vector3

2 participants