Docs: Fix redirect exception in Firefox. #26033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Can you provide a URL that triggers the error message in the browser console? |
Contributor
Author
Collaborator
|
This URL does not produce an error in the browser console. At least with latest Chrome. Do I miss something? |
Contributor
Author
the spec did not elaborate about this, so its up to browsers. 🔥🦊<try |
Mugen87
approved these changes
May 12, 2023
Collaborator
Mugen87
left a comment
Mugen87
left a comment
There was a problem hiding this comment.
Okay, thanks! Indeed, I see the error with Firefox on macOS. Chrome and Safari are fine. It also seems it is some sort of timing issue. When I debug the code in FF, no runtime error happens.
But in any event, the PR fixes the issue and also performs a nice clean up 👍 .
Mugen87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR 1) cleanup, 2) ensures that not listen domcontentloaded if location.replace() get called, in order to tackle the annoying error message when redirection takes place, e.g. landing on pages suggested by duckduckgo
ff console (or other browsers w/ persistent log):