USDZExporter: Improve UsdTransform2d #26023
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

This PR fixes UsdTransform2d rotation for usdview and other USD-spec-compliant viewers that support the UsdTransform2d schema.
Notably, QuickLook does things differently. There is currently a const in the code to switch between QuickLook behaviour (which is not 100% correct yet, but comes close) and proper behaviour. Unfortunately there doesn't seem to be a way to make both happy until Apple fixes their bugs.
I believe we want to default to the QuickLook behaviour (and hopefully get that fixed) since e.g. model-viewer's main target is conversion to that.
Here is a better test file - the glTF sample model is not sufficiently accurate to show the QuickLook errors:
BetterTextureTransformTests.zip
This contribution is funded by Needle