Improve webgl2_multisampled_renderbuffers example.
#26005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
commented
May 7, 2023
| container = document.getElementById( 'container' ); | ||
|
|
||
| camera = new THREE.PerspectiveCamera( 45, container.offsetWidth / container.offsetHeight, 1, 2000 ); | ||
| camera = new THREE.PerspectiveCamera( 45, container.offsetWidth / container.offsetHeight, 10, 2000 ); |
Collaborator
Author
There was a problem hiding this comment.
Previous version has z-fighting issues, depending on the seed.
WestLangley
commented
May 7, 2023
| color: 0xee0808, | ||
| polygonOffset: true, | ||
| polygonOffsetFactor: 1, // positive value pushes polygon further away | ||
| polygonOffsetUnits: 1 |
Collaborator
Author
There was a problem hiding this comment.
This improves the render of the wireframe.
WestLangley
commented
May 7, 2023
| const material2 = new THREE.MeshBasicMaterial( { color: 0xffffff, wireframe: true } ); | ||
|
|
||
| for ( let i = 0; i < 10; i ++ ) { | ||
| for ( let i = 0; i < 50; i ++ ) { |
Collaborator
Author
There was a problem hiding this comment.
More to look at :-)
WestLangley
commented
May 7, 2023
| // | ||
|
|
||
| const gui = new GUI(); | ||
| gui.add( params, 'animate' ); |
Collaborator
Author
There was a problem hiding this comment.
Animation was obfuscating rendering issues. Allow animation to be disabled.
WestLangley
commented
May 7, 2023
| group.rotation.y += clock.getDelta() * 0.1; | ||
| if ( params.animate ) { | ||
|
|
||
| group.rotation.y += 0.002; |
Collaborator
Author
There was a problem hiding this comment.
Remove clock so a restarted animation continues where it left off -- and does not jump.
Mugen87
approved these changes
May 7, 2023
Mugen87
changed the title
webgl2_multisampled_renderbuffers example.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat subjective. Suggestions welcome.