Skip to content

Examples: Use new gpuType field in GPU Picking, fix bugs #26001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 7, 2023
Merged

Examples: Use new gpuType field in GPU Picking, fix bugs #26001

merged 3 commits into from
May 7, 2023

Conversation

@gkjohnson
Copy link
Collaborator

@gkjohnson gkjohnson commented May 6, 2023

Related issue: --

Description

  • Use an Int 16 vertex attribute and set the gpuType appropriately
  • Update BufferGeometryUtils.mergeAttributes to be aware of gpuType
  • Use RGBAFormat texture instead of RedFormat since firefox seems to require it

@Mugen87 Mugen87 added this to the r153 milestone May 6, 2023
@mrdoob mrdoob merged commit 783185a into mrdoob:dev May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mugen87 Mugen87 Mugen87 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

r153

Development

Successfully merging this pull request may close these issues.

3 participants

@gkjohnson @Mugen87 @mrdoob