Example: Update GPU picking to use integer Ids, target #25983
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
commented
May 4, 2023
Comment on lines
+124
to
+126
| const position = geometry.attributes.position; | ||
| const array = new Int32Array( position.count ); | ||
| array.fill( id ); |
Collaborator
Author
There was a problem hiding this comment.
Once #21606 is merged I would like to change this to an Int16 array and use the new "integer" declaration field here.
gkjohnson
commented
May 4, 2023
gkjohnson
commented
May 4, 2023
Comment on lines
+258
to
+259
| clearColor.setRGB( - 1, - 1, - 1 ); | ||
| renderer.setClearColor( clearColor ); |
Collaborator
Author
There was a problem hiding this comment.
Not a huge deal but setting the clear color to something not representable with a hex value is a bit inconvenient here since it requires creating an intermediate color object.
LeviPesin
reviewed
May 4, 2023
Mugen87
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #25952 (comment)
Description
Updates the GPU picking example to use an integer vertex attribute, 32 bit integer target for rendering rather than the color-based approach that required using bit shifts on color values to reconstitute the id.
Note - I realized that no changes were needed to ShaderMaterial in order to enable rendering to an integer target since using GLSL3 enables control over the output type.
edit: also addresses and issue that was causing the 0th box to be selected when hovering over the background