Examples: Updates for color management (pt2) #25882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
commented
Apr 18, 2023
donmccurdy
commented
Apr 18, 2023
Collaborator
Author
|
@gkjohnson @Mugen87 I've updated the PR, hopefully a good balance of the concerns here? |
Mugen87
approved these changes
Apr 19, 2023
WestLangley
reviewed
Apr 19, 2023
WestLangley
reviewed
Apr 19, 2023
WestLangley
reviewed
Apr 19, 2023
donmccurdy
changed the title
emmanueljl
pushed a commit
to emmanueljl/three.js
that referenced
this pull request
Apr 28, 2023
* Examples: Update misc_exporter_gltf and misc_exporter_ply for color management. * Examples: Update 3MF examples for color management. * Examples: Update webgl_loader_draco for color management. * Examples: Update LDraw examples for color management. * Loaders: Update color space assignmentin 3MF, LDraw, and SVG loaders. * LDrawLoader: Clean up, fix emissive. * LDrawLoader: Clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: