WebGPURenderer: Request all supported features.#25875
Merged
Merged
Conversation
LeviPesin
reviewed
Apr 18, 2023
emmanueljl
pushed a commit
to emmanueljl/three.js
that referenced
this pull request
Apr 28, 2023
38 tasks
Collaborator
|
Nit: If we want to request all supported features, we may make an array from const supportedFeatures = [];
for (const feature of adapter.features.values()) {
supportedFeatures.push(feature);
}Note that https://webidl.spec.whatwg.org/#es-setlike Pros: We don't need to manage features list for this purpose. Even if new features added in the WebGPU spec, we don't need to update the code. |
Collaborator
Author
That is a good point. I suppose not supporting certain features could become useful so I guess the current approach is more flexible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #25867
Description
In order to solve the issue outlined in #25867 (comment),
WebGPURendererrequest all supported features of a device now.