Examples: Clean up legacy .outputColorSpace = LinearSRGBColorSpace examples (part 1) #25844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
commented
Apr 16, 2023
| const geometry = new THREE.BoxGeometry( 1, 1, 1 ); | ||
| geometry.translate( 0, 0.5, 0 ); | ||
| const material = new THREE.MeshPhongMaterial( { color: 0xffffff, flatShading: true } ); | ||
| const material = new THREE.MeshPhongMaterial( { color: 0xeeeeee, flatShading: true } ); |
Collaborator
Author
There was a problem hiding this comment.
This line is just an artistic change. Contrast was lower with the corrected color workflow, so I brought a bit of contrast back.
Collaborator
I've filed this PR mainly for testing purposes and to get myself more familiar with this change to easier provide support and doing some integration testing. I'll close the PR since cleaning up the merge conflicts will take longer than actually filing the PR from a clean rebased |
donmccurdy
changed the title
This was referenced Apr 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up a few (5 / 65) of the remaining examples using
.outputColorSpace = LinearSRGBColorSpace. Eventually we should do this for all examples that don't have a reason for Linear-sRGB output. The only reason at the moment would be post-processing.I'll do similar changes for more examples if there are no objections. This create minor merge conflicts with #25830, but also might make it easier to solve remaining issues in that PR.
Related: