Skip to content

Conversation

@querielo
Copy link
Contributor

@querielo querielo commented Apr 10, 2023

The PR fixes a misprint.

It looks like we have to copy source.viewport/source.scissor instead of cleaning this.viewport/this.scissor:

		this.viewport.set( 0, 0, this.width, this.height );
		this.scissor.set( 0, 0, this.width, this.height );

@github-actions
Copy link

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize Gzipped Diff from dev
633.5 kB 157 kB -31 B

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize Gzipped Diff from dev
424.8 kB 103 kB +0 B

@Mugen87 Mugen87 added this to the r152 milestone Apr 10, 2023
@Mugen87 Mugen87 changed the title [WebGLMultipleRenderTargets.prototype.copy] Fix misprint: copy viewport/scissor from source WebGLMultipleRenderTargets: Copy viewport/scissor from source. Apr 10, 2023
@Mugen87 Mugen87 merged commit 27de13e into mrdoob:dev Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants