Skip to content

Nodes: Rework ShaderNodeElements and make some other refactorings #25498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Nodes: Rework ShaderNodeElements and make some other refactorings #25498

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
2f370d1
Nodes: Rework ShaderNodeElements and make some other refactorings
LeviPesin Feb 13, 2023
2496ef6
Fixes
LeviPesin Feb 13, 2023
681549f
fix add assign
sunag Feb 13, 2023
d1100a6
Fix circular dependency and clean up
LeviPesin Feb 14, 2023
2036fe7
Merge branch 'refactor-shadernodeelements' of https://github.com/Levi…
LeviPesin Feb 14, 2023
bf220f1
Merge branch 'mrdoob:dev' into refactor-shadernodeelements
LeviPesin Feb 14, 2023
6bb80ef
Rename addNode -> addNodeElement and LightsNode.setReference -> addLi…
LeviPesin Feb 15, 2023
2328440
Merge branch 'refactor-shadernodeelements' of https://github.com/Levi…
LeviPesin Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/webgpu_lights_custom.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@

const { lightColor, reflectedLight } = inputs;

reflectedLight.directDiffuse.add( lightColor );
reflectedLight.directDiffuse.addAssign( lightColor );

} );

Expand Down