Skip to content

BufferAttribute: Make normalized parameter to be optional. #25046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2022
Merged

BufferAttribute: Make normalized parameter to be optional. #25046

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e0f2bc
BufferAttribute: Make `normalized` parameter to be optional.
linbingquan Nov 30, 2022
c507fb8
InterleavedBufferAttribute: Removed useless code.
linbingquan Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/BufferAttribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ const _vector2 = /*@__PURE__*/ new Vector2();

class BufferAttribute {

constructor( array, itemSize, normalized ) {
constructor( array, itemSize, normalized = false ) {

if ( Array.isArray( array ) ) {

Expand All @@ -23,7 +23,7 @@ class BufferAttribute {
this.array = array;
this.itemSize = itemSize;
this.count = array !== undefined ? array.length / itemSize : 0;
this.normalized = normalized === true;
this.normalized = normalized;

this.usage = StaticDrawUsage;
this.updateRange = { offset: 0, count: - 1 };
Expand Down