PMREMGenerator: Set RenderTargets minFilter to NearestFilter only in the blur pass #23511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@PavelBoytchev on twitter confirmed that this still solves the black lines issue 🎉 |
Owner
Author
|
This other tool is a bit more useful.
@elalish These are the pixels that change when doing the blur inside PMREM using nearest instead of linear. |
Contributor
|
Okay, well that's what I was afraid of. Yeah, Nearest isn't the "right" solution, though it may have to do for now. Unless we find a better workaround. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #23468 (comment)
Description
Setting
minFilterto NearestFilter produced darker render. This sets it only during the blur pass.I'll merge but I'll also check with the nvidia users to make sure this workaround works for them.