WebGLRenderer: Limited WebGL1 backwards compatibility for transmission. #23452
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
/cc @haxiomic |
Mugen87
reviewed
Feb 10, 2022
Owner
Author
|
@elalish FYI |
Contributor
|
Awesome! And I agree that full-res is the way to go; really you can only safely go lower if there's some roughness applied to the transmissive surface, or its geometry is complex. No good way to check for that. |
donmccurdy
pushed a commit
to donmccurdy/three.js
that referenced
this pull request
Mar 10, 2022
…n. (mrdoob#23452) * WebGLRenderer: Limited WebGL1 backwards compatibility for transmission. * Update WebGLRenderer.js * Updated docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #22731 #23450
Description
Rather than completely removing transmission support in WebGL1, I think we can provide limited support by ignoring roughness (mipmapping).
I've also increased the
_transmissionRenderTargetresolution to 1x which fully solves issue 5 in #22009.