Skip to content

Use number of indices instead of vertices when setting draw range #23435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 6, 2022
Merged

Use number of indices instead of vertices when setting draw range #23435

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d73ed8
Use number of indices instead of vertices when setting draw range
jure Feb 6, 2022
8cfa40c
Set default number of birds to 1024
jure Feb 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/webgl_gpgpu_birds_gltf.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@

/* BAKE ANIMATION INTO TEXTURE and CREATE GEOMETRY FROM BASE MODEL */
const BirdGeometry = new THREE.BufferGeometry();
let textureAnimation, durationAnimation, birdMesh, materialShader, vertexPerBird;
let textureAnimation, durationAnimation, birdMesh, materialShader, indicesPerBird;

function nextPowerOf2( n ) {

Expand All @@ -260,7 +260,7 @@
const morphAttributes = birdGeo.morphAttributes.position;
const tHeight = nextPowerOf2( durationAnimation );
const tWidth = nextPowerOf2( birdGeo.getAttribute( 'position' ).count );
vertexPerBird = birdGeo.getAttribute( 'position' ).count;
indicesPerBird = birdGeo.index.count;
const tData = new Float32Array( 4 * tWidth * tHeight );

for ( let i = 0; i < tWidth; i ++ ) {
Expand Down Expand Up @@ -414,7 +414,7 @@
cohesion: 20.0,
freedom: 0.75,
size: sizes[ selectModel ],
count: BIRDS
count: Math.floor( BIRDS / 4 )

};

Expand All @@ -425,7 +425,7 @@
velocityUniforms[ "cohesionDistance" ].value = effectController.cohesion;
velocityUniforms[ "freedomFactor" ].value = effectController.freedom;
if ( materialShader ) materialShader.uniforms[ "size" ].value = effectController.size;
BirdGeometry.setDrawRange( 0, vertexPerBird * effectController.count );
BirdGeometry.setDrawRange( 0, indicesPerBird * effectController.count );

};

Expand Down